HIVE-29671: Harden Schema path authorization for avro serde#6549
Merged
saihemanth-cloudera merged 6 commits intoJul 9, 2026
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Avro SerDe schema resolution by restricting/validating avro.schema.url schemes (and optionally allowlisting HTTP hosts), and extends Hive authorization plumbing so filesystem-based schema URLs are authorized as DFS_URI inputs during create/alter and query-time reads.
Changes:
- Add scheme/host validation for
avro.schema.url, disable remote HTTP fetch by default, and materialize resolved schemas intoavro.schema.literal. - Enrich authorization inputs to include filesystem-backed Avro schema URLs (metastore events + query authorization paths).
- Add new HiveConf knobs and expand unit/integration test coverage for the new behavior.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java |
Validates schema URL scheme/host and changes how schemas are fetched/materialized. |
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerdeUtils.java |
Adds tests for scheme/host validation and schema materialization. |
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java |
Introduces new config vars for allowed schemes and remote HTTP settings/allowlist. |
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java |
Adds helpers to derive/authorize filesystem schema URL inputs on reads. |
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java |
Enriches read inputs before privilege checks to include schema URL entities. |
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java |
Hooks input addition to also add schema URL read entities. |
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/CreateTableEvent.java |
Adds DFS_URI privilege objects for Avro avro.schema.url at create time. |
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/AlterTableEvent.java |
Adds DFS_URI privilege objects for updated Avro avro.schema.url at alter time. |
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/TestAvroSchemaUrlAuthorizationUtils.java |
New unit tests for schema URL authorization utilities. |
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java |
Adds/adjusts metastore authorizer tests for DFS_URI objects from schema URLs. |
ql/src/test/results/clientpositive/llap/compustat_avro.q.out |
Updates golden output masking lines affected by input changes. |
ql/src/test/results/clientpositive/llap/avro_extschema_insert.q.out |
Updates golden output masking lines affected by input changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
Contributor
Author
|
@dengzhhu653 - Can you review this? Tests are finally green after many flaky runs. |
dengzhhu653
reviewed
Jul 7, 2026
dengzhhu653
reviewed
Jul 7, 2026
dengzhhu653
reviewed
Jul 7, 2026
| if (!AvroSerdeUtils.isFilesystemSchemaUrl(schemaUrl)) { | ||
| return; | ||
| } | ||
| if (!needDFSUriAuth(schemaUrl, getDefaultTablePath(database, table))) { |
Member
There was a problem hiding this comment.
this schemaUrl shouldn't be the same as table's location,
dengzhhu653
reviewed
Jul 7, 2026
dengzhhu653
reviewed
Jul 7, 2026
dengzhhu653
reviewed
Jul 7, 2026
dengzhhu653
reviewed
Jul 8, 2026
| if (schemaUrl == null) { | ||
| return; | ||
| } | ||
| if (!needDFSUriAuth(schemaUrl, getDefaultTablePath(database, table))) { |
Member
There was a problem hiding this comment.
why do we check the schemaUrl against the getDefaultTablePath(database, table), they are different
dengzhhu653
reviewed
Jul 8, 2026
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
dengzhhu653
approved these changes
Jul 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?